You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR introduces the workflow for creating the multi-module release. Also added testing for the scripts, including a pretty basic testing "framework".
Requirements for it to work:
Create a GitHub environment named releasethat has a token called RELEASE_TOKEN able to push to main1 and only ever reads from main.
This was a security concern flagged by the AI.
Workflow runs should require multiple maintainer approvals.
This will apply to dry-runs too.
Deferred improvements:
Add logic so that fixing half-way done releases is easier.
The next release must be v1.2.0, as that is the lowest available for all the current modules. The workflow should break for anything lower. I would suggest doing a v1.2.0-pre.1 (dry-run, then real) as a test as well to make sure everything works correctly.
AI disclosure:
The PR is heavily AI-authored, specifically Claude Sonnet 5.5 through Cursor.
Footnotes
The current implementation reuses the kptdev-ci-bot's token instead ↩
The reason will be displayed to describe this comment to others. Learn more.
🟡 Changes recommended
The workflow can execute code from a non-main input branch with the privileged RELEASE_TOKEN because environment restrictions check the dispatch ref rather than the branch being checked out.
Introduces a manual, lock-step release process for kpt’s API, root library, and CLI modules, addressing #4827 by coordinating their versions and publishing one GitHub release.
Changes:
Consolidates release workflows with validation, dependency bumps, atomic pushes, dry runs, and provenance.
Adds release scripts and tests for version ordering, tagging, notes, and asset staging.
Updates GoReleaser configuration and maintainer documentation.
File
Description
scripts/multimodule-release/release.sh
Dispatches release subcommands.
scripts/multimodule-release/lib/validate.sh
Validates versions against remote module tags.
scripts/multimodule-release/lib/testing.sh
Provides assertions and isolated repository fixtures.
The reason will be displayed to describe this comment to others. Learn more.
🟡 Changes recommended
Active release-blocking issues remain: the workflow uses inconsistent required credentials, rejects the current checkout’s intentional replacements before testing, and lacks the mandated minimum-version check.
The validation only compares the requested version with the highest existing tags, so a version such as v1.1.2 would pass when the current tags are below that version. The PR requirements say the first lock-step release must be on the v1.2.0 release line (while allowing a v1.2.0 prerelease); add an explicit floor check and a regression test so the workflow cannot publish an earlier line.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4827
This PR introduces the workflow for creating the multi-module release. Also added testing for the scripts, including a pretty basic testing "framework".
Requirements for it to work:
releasethat has a token called1 and only ever reads from main.RELEASE_TOKENable to push to mainDeferred improvements:
The next release must be v1.2.0, as that is the lowest available for all the current modules. The workflow should break for anything lower. I would suggest doing a v1.2.0-pre.1 (dry-run, then real) as a test as well to make sure everything works correctly.
AI disclosure:
The PR is heavily AI-authored, specifically Claude Sonnet 5.5 through Cursor.
Footnotes
The current implementation reuses the kptdev-ci-bot's token instead ↩